fix: surface statement-level query errors and fix debug-mode crash#451
Open
MagnunAVFAzion wants to merge 4 commits into
Open
fix: surface statement-level query errors and fix debug-mode crash#451MagnunAVFAzion wants to merge 4 commits into
MagnunAVFAzion wants to merge 4 commits into
Conversation
Contributor
SCC Complexity Analysis
|
Contributor
SCC Complexity Analysis
|
MagnunAVFAzion
changed the title
Contributor
SCC Complexity Analysis
|
commit: |
jcbsfilho
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens error handling in the SQL package's
postQueryDatabase:Fixes a crash in debug mode. When the SQL API returned a per-statement
result array containing a
nullentry (e.g.[{ error: 'no such table: ...' }, null]),the debug
.map()accessed.resultsonnulland threwCannot read properties of null (reading 'results').Surfaces statement-level errors. The API reports per-statement failures
inside the
dataarray rather than in top-levelresult.errors. These arenow detected and returned as a proper
errorobject, instead of being buriedin the response data.
Updates docs to make the "check
errorbeforedata" behavior explicit.Problem Reproduction
Running a query (in localhost - nodejs server) against a non-existent table with debug true produced:
instead of a clean error response.